diff --git a/server/tests/conftest.py b/server/tests/conftest.py new file mode 100644 index 0000000..dc26478 --- /dev/null +++ b/server/tests/conftest.py @@ -0,0 +1,41 @@ +from __future__ import annotations + +import os + +import pytest +from sqlalchemy import create_engine, text + +from app.storage.db import Database +from app.storage.models import Base + +TEST_DATABASE_URL = os.environ.get( + "GNEXUS_BOOK_TEST_DATABASE_URL", + "postgresql+psycopg://gmikcon@127.0.0.1:5433/gnexus_book_test", +) + + +@pytest.fixture(scope="session") +def database_url() -> str: + engine = create_engine(TEST_DATABASE_URL) + try: + with engine.connect() as connection: + connection.execute(text("SELECT 1")) + except Exception as exc: # pragma: no cover - depends on local environment + pytest.skip(f"PostgreSQL test database is unavailable: {exc}") + finally: + engine.dispose() + return TEST_DATABASE_URL + + +@pytest.fixture() +def database(database_url: str) -> Database: + engine = create_engine(database_url) + Base.metadata.drop_all(engine) + Base.metadata.create_all(engine) + + db = Database(database_url) + try: + yield db + finally: + Base.metadata.drop_all(engine) + engine.dispose() diff --git a/server/tests/test_db_storage.py b/server/tests/test_db_storage.py new file mode 100644 index 0000000..e47dcf9 --- /dev/null +++ b/server/tests/test_db_storage.py @@ -0,0 +1,96 @@ +from __future__ import annotations + +import pytest + +from app.config import Settings +from app.docs_repository import DocsRepository +from app.inventory import InventoryRepository +from app.pending_changes import PendingChangeError, PendingChangeRepository, ProposedChangeRequest +from app.storage.db import Database +from app.storage.db_repositories import PostgresDocsRepository, PostgresInventoryRepository +from app.storage.factory import make_docs_repository, make_inventory_repository +from app.storage.importer import database_counts, import_file_repository +from app.storage.parity import compare_repositories + + +@pytest.fixture() +def imported(database: Database) -> tuple[Settings, Database]: + settings = Settings(storage_backend="db", database_url=database.url) + report = import_file_repository(settings, database, replace=True) + assert report.documents > 0 + assert report.inventory_items > 0 + return settings, database + + +def test_read_parity_with_file_backend(imported: tuple[Settings, Database]) -> None: + settings, database = imported + result = compare_repositories(settings, database) + + assert result["ok"], result["differences"][:3] + + +def test_import_is_repeatable(imported: tuple[Settings, Database]) -> None: + settings, database = imported + before = database_counts(database) + + import_file_repository(settings, database, replace=True) + + assert database_counts(database) == before + + +def test_factory_selects_database_backend(imported: tuple[Settings, Database]) -> None: + settings, _ = imported + + assert isinstance(make_docs_repository(settings), PostgresDocsRepository) + assert isinstance(make_inventory_repository(settings), PostgresInventoryRepository) + + +def test_factory_defaults_to_file_backend() -> None: + settings = Settings(storage_backend="file") + + assert isinstance(make_docs_repository(settings), DocsRepository) + assert isinstance(make_inventory_repository(settings), InventoryRepository) + + +def test_search_matches_file_backend(imported: tuple[Settings, Database]) -> None: + settings, database = imported + file_repo = DocsRepository(Settings(repo_root=settings.repo_root, storage_backend="file")) + db_repo = PostgresDocsRepository(database) + + assert file_repo.search("GitBucket") == db_repo.search("GitBucket") + assert file_repo.search("") == db_repo.search("") + + +def test_inventory_item_lookup(imported: tuple[Settings, Database]) -> None: + _, database = imported + repo = PostgresInventoryRepository(database) + + assert repo.read_item("services", "gitbucket")["name"] == "GitBucket" + + with pytest.raises(Exception, match="Inventory item not found"): + repo.read_item("services", "does-not-exist") + + +def test_document_read_returns_expected_shape(imported: tuple[Settings, Database]) -> None: + _, database = imported + repo = PostgresDocsRepository(database) + document = repo.read_doc("10-systems/applications/gitbucket.md") + + assert set(document) == {"path", "frontmatter", "body", "raw"} + assert "GitBucket" in document["body"] + assert document["frontmatter"]["owner"] == "gmikcon" + + +def test_file_write_path_is_blocked_in_database_mode(imported: tuple[Settings, Database]) -> None: + settings, _ = imported + repo = PendingChangeRepository(settings) + + with pytest.raises(PendingChangeError, match="database mode"): + repo.create( + ProposedChangeRequest( + kind="doc", + target="10-systems/example.md", + summary="Example", + payload={"content": "# Example"}, + ) + ) diff --git a/server/tests/test_migrations.py b/server/tests/test_migrations.py new file mode 100644 index 0000000..5107eed --- /dev/null +++ b/server/tests/test_migrations.py @@ -0,0 +1,49 @@ +from __future__ import annotations + +import uuid +from pathlib import Path + +import pytest +from alembic import command +from alembic.config import Config +from sqlalchemy import create_engine, inspect, text + + +@pytest.fixture() +def temporary_database_url(database_url: str) -> str: + engine = create_engine(database_url, isolation_level="AUTOCOMMIT") + name = f"gnexus_book_migration_{uuid.uuid4().hex[:8]}" + with engine.connect() as connection: + connection.execute(text(f'CREATE DATABASE "{name}"')) + url = database_url.rsplit("/", 1)[0] + "/" + name + try: + yield url + finally: + with engine.connect() as connection: + connection.execute(text(f'DROP DATABASE IF EXISTS "{name}" WITH (FORCE)')) + engine.dispose() + + +def test_alembic_upgrade_creates_schema( + temporary_database_url: str, monkeypatch: pytest.MonkeyPatch +) -> None: + monkeypatch.setenv("GNEXUS_BOOK_DATABASE_URL", temporary_database_url) + config = Config(str(Path(__file__).resolve().parents[1] / "alembic.ini")) + config.set_main_option("sqlalchemy.url", temporary_database_url) + + command.upgrade(config, "head") + + engine = create_engine(temporary_database_url) + try: + tables = set(inspect(engine).get_table_names()) + finally: + engine.dispose() + + assert { + "alembic_version", + "documents", + "doc_versions", + "inventory_items", + "changesets", + "users", + } <= tables